Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print builtin #934

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Print builtin #934

merged 1 commit into from
Jan 24, 2024

Conversation

chriseth
Copy link
Member

@chriseth chriseth commented Jan 23, 2024

No description provided.

@chriseth chriseth force-pushed the print branch 2 times, most recently from 1440f10 to d7d87e2 Compare January 23, 2024 13:52
@chriseth chriseth force-pushed the builtins branch 2 times, most recently from c5e5597 to 3e3349d Compare January 23, 2024 19:30
Base automatically changed from builtins to main January 23, 2024 20:57
@chriseth chriseth changed the base branch from main to special_identifiers January 24, 2024 06:44
@chriseth chriseth force-pushed the special_identifiers branch from 85de6ea to 4865ac8 Compare January 24, 2024 06:46
@chriseth chriseth force-pushed the special_identifiers branch from 4865ac8 to 1b24ac3 Compare January 24, 2024 08:32
@chriseth chriseth force-pushed the print branch 3 times, most recently from f2be0cb to 25e5553 Compare January 24, 2024 10:50
@@ -67,6 +67,29 @@ pub fn parse_module<'a, T: FieldElement>(
.map_err(|err| handle_parse_error(err, file_name, input))
}

/// Parse an escaped string - used in the grammar.
pub fn unescape_string(s: &str) -> String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no utility for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. we could use an external crate for that, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea better not

@leonardoalt leonardoalt merged commit d39e58b into special_identifiers Jan 24, 2024
2 checks passed
@leonardoalt leonardoalt deleted the print branch January 24, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants